Fix precompiled headers with C files #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albestro
approved these changes
Aug 16, 2023
rasolca
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around #950 with https://stackoverflow.com/questions/68735830/cmake-precompiled-headers-issue-with-mixed-c-c-project. Note that it's not enough to have a C header in the list of precompiled headers. The executable/library also has to have at least one C file for the
.hprecompiled header to be generated. In C-mode-Wpedanticalso warns about an empty translation unit so I've added a dummy function declaration to thedummy.cfile as well.